Re: [PATCH v6 0/5] dump: Make most of it target agnostic (build once)

[Marc-André Lureau]

On Sat, Feb 25, 2023 at 1:49 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

All series reviewed.

Since v5:
- reword one commit description (Thomas)
- drop CONFIG_SOFTMMU, unify softmmu_ss (Richard)

Since v4:
- more unused headers removed
- KISS, use a bit of #ifdef'ry to avoid a stub file

Thanks to Richard help, we can now build dump.o once
for all targets, keeping win_dump.o for x86* targets.

Philippe Mathieu-Daudé (5):
  dump: Replace tswapN() -> cpu_to_dumpN()
  dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size()
  dump: Clean included headers
  dump: Simplify compiling win_dump.o by introducing
    win_dump_available()
  dump: Add create_win_dump() stub for non-x86 targets

 dump/dump-hmp-cmds.c |  2 +-
 dump/dump.c          | 35 +++++++++++++----------------------
 dump/meson.build     |  6 ++----
 dump/win_dump.c      | 38 ++++++++++++++++++++++++++++----------
 dump/win_dump.h      |  5 ++++-
 5 files changed, 48 insertions(+), 38 deletions(-)

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>