[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 1/5] dump: Replace tswapN() -> cpu_to_dumpN()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v6 1/5] dump: Replace tswapN() -> cpu_to_dumpN() |
Date: |
Sat, 25 Feb 2023 10:48:59 +0100 |
All uses of tswap in that file are wrong, and should be using
cpu_to_dumpN, which correctly tests the endianness of the output.
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
dump/dump.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dump/dump.c b/dump/dump.c
index 1362810991..0ab229e5e9 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -907,13 +907,13 @@ static void get_note_sizes(DumpState *s, const void *note,
if (dump_is_64bit(s)) {
const Elf64_Nhdr *hdr = note;
note_head_sz = sizeof(Elf64_Nhdr);
- name_sz = tswap64(hdr->n_namesz);
- desc_sz = tswap64(hdr->n_descsz);
+ name_sz = cpu_to_dump64(s, hdr->n_namesz);
+ desc_sz = cpu_to_dump64(s, hdr->n_descsz);
} else {
const Elf32_Nhdr *hdr = note;
note_head_sz = sizeof(Elf32_Nhdr);
- name_sz = tswap32(hdr->n_namesz);
- desc_sz = tswap32(hdr->n_descsz);
+ name_sz = cpu_to_dump32(s, hdr->n_namesz);
+ desc_sz = cpu_to_dump32(s, hdr->n_descsz);
}
if (note_head_size) {
--
2.38.1
- [PATCH v6 0/5] dump: Make most of it target agnostic (build once), Philippe Mathieu-Daudé, 2023/02/25
- [PATCH v6 1/5] dump: Replace tswapN() -> cpu_to_dumpN(),
Philippe Mathieu-Daudé <=
- [PATCH v6 2/5] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size(), Philippe Mathieu-Daudé, 2023/02/25
- [PATCH v6 3/5] dump: Clean included headers, Philippe Mathieu-Daudé, 2023/02/25
- [PATCH v6 4/5] dump: Simplify compiling win_dump.o by introducing win_dump_available(), Philippe Mathieu-Daudé, 2023/02/25
- [PATCH v6 5/5] dump: Add create_win_dump() stub for non-x86 targets, Philippe Mathieu-Daudé, 2023/02/25
- Re: [PATCH v6 0/5] dump: Make most of it target agnostic (build once), Marc-André Lureau, 2023/02/26