Re: [PATCH v3 14/30] tcg: Use tcg_constant_ptr in do_dup

[Daniel Henrique Barboza]

On 2/25/23 05:59, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

>   tcg/tcg-op-gvec.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c
> index a10d406bba..877b0b659b 100644
> --- a/tcg/tcg-op-gvec.c
> +++ b/tcg/tcg-op-gvec.c
> @@ -630,7 +630,7 @@ static void do_dup(unsigned vece, uint32_t dofs, uint32_t 
> oprsz,
>        * stores through to memset.
>        */
>       if (oprsz == maxsz && vece == MO_8) {
> -        TCGv_ptr t_size = tcg_const_ptr(oprsz);
> +        TCGv_ptr t_size = tcg_constant_ptr(oprsz);
>           TCGv_i32 t_val;
>   
>           if (in_32) {
> @@ -646,7 +646,6 @@ static void do_dup(unsigned vece, uint32_t dofs, uint32_t 
> oprsz,
>           if (in_64) {
>               tcg_temp_free_i32(t_val);
>           }
> -        tcg_temp_free_ptr(t_size);
>           tcg_temp_free_ptr(t_ptr);
>           return;
>       }