[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 16/30] accel/tcg/plugin: Tidy plugin_gen_disable_mem_helpers
From: |
Richard Henderson |
Subject: |
[PATCH v3 16/30] accel/tcg/plugin: Tidy plugin_gen_disable_mem_helpers |
Date: |
Fri, 24 Feb 2023 22:59:31 -1000 |
Here we are creating a temp whose value needs to be replaced,
but always storing NULL into CPUState.plugin_mem_cbs.
Use tcg_constant_ptr(0) explicitly.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/plugin-gen.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index 9b793ac62c..c42a436c0c 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -630,8 +630,6 @@ static void inject_mem_disable_helper(struct
qemu_plugin_insn *plugin_insn,
/* called before finishing a TB with exit_tb, goto_tb or goto_ptr */
void plugin_gen_disable_mem_helpers(void)
{
- TCGv_ptr ptr;
-
/*
* We could emit the clearing unconditionally and be done. However, this
can
* be wasteful if for instance plugins don't track memory accesses, or if
@@ -644,10 +642,8 @@ void plugin_gen_disable_mem_helpers(void)
if (!tcg_ctx->plugin_tb->mem_helper) {
return;
}
- ptr = tcg_const_ptr(NULL);
- tcg_gen_st_ptr(ptr, cpu_env, offsetof(CPUState, plugin_mem_cbs) -
- offsetof(ArchCPU, env));
- tcg_temp_free_ptr(ptr);
+ tcg_gen_st_ptr(tcg_constant_ptr(NULL), cpu_env,
+ offsetof(CPUState, plugin_mem_cbs) - offsetof(ArchCPU,
env));
}
static void plugin_gen_tb_udata(const struct qemu_plugin_tb *ptb,
--
2.34.1
- Re: [PATCH v3 10/30] tcg: Use tcg_constant_i32 in tcg_gen_io_start, (continued)
- [PATCH v3 11/30] tcg: Add tcg_gen_movi_ptr, Richard Henderson, 2023/02/25
- [PATCH v3 14/30] tcg: Use tcg_constant_ptr in do_dup, Richard Henderson, 2023/02/25
- [PATCH v3 13/30] tcg: Use tcg_temp_ebb_new_* in tcg/, Richard Henderson, 2023/02/25
- [PATCH v3 19/30] target/arm: Drop copies in gen_sve_{ldr,str}, Richard Henderson, 2023/02/25
- [PATCH v3 15/30] accel/tcg/plugin: Use tcg_temp_ebb_*, Richard Henderson, 2023/02/25
- [PATCH v3 16/30] accel/tcg/plugin: Tidy plugin_gen_disable_mem_helpers,
Richard Henderson <=
- [PATCH v3 12/30] tcg: Add tcg_temp_ebb_new_{i32,i64,ptr}, Richard Henderson, 2023/02/25
- [PATCH v3 24/30] target/i386: Don't use tcg_temp_local_new, Richard Henderson, 2023/02/25
- [PATCH v3 21/30] target/cris: Don't use tcg_temp_local_new, Richard Henderson, 2023/02/25
- [PATCH v3 23/30] target/hppa: Don't use tcg_temp_local_new, Richard Henderson, 2023/02/25
- [PATCH v3 29/30] tcg: Remove tcg_temp_local_new_*, tcg_const_local_*, Richard Henderson, 2023/02/25
- [PATCH v3 27/30] target/xtensa: Don't use tcg_temp_local_new_*, Richard Henderson, 2023/02/25
- [PATCH v3 28/30] exec/gen-icount: Don't use tcg_temp_local_new_i32, Richard Henderson, 2023/02/25
- [PATCH v3 30/30] tcg: Update docs/devel/tcg-ops.rst for temporary changes, Richard Henderson, 2023/02/25
- [PATCH v3 17/30] tcg: Don't re-use TEMP_TB temporaries, Richard Henderson, 2023/02/25