[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 2/5] intel-iommu: fail DEVIOTLB_UNMAP without dt mode
From: |
Jason Wang |
Subject: |
[PATCH V2 2/5] intel-iommu: fail DEVIOTLB_UNMAP without dt mode |
Date: |
Thu, 23 Feb 2023 14:59:21 +0800 |
Without dt mode, device IOTLB notifier won't work since guest won't
send device IOTLB invalidation descriptor in this case. Let's fail
early instead of misbehaving silently.
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Tested-by: Laurent Vivier <lvivier@redhat.com>
Tested-by: Viktor Prutyanov <viktor@daynix.com>
Buglink: https://bugzilla.redhat.com/2156876
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/i386/intel_iommu.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 0de3e31577..f006fa6031 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3179,6 +3179,7 @@ static int
vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
{
VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);
IntelIOMMUState *s = vtd_as->iommu_state;
+ X86IOMMUState *x86_iommu = X86_IOMMU_DEVICE(s);
/* TODO: add support for VFIO and vhost users */
if (s->snoop_control) {
@@ -3193,6 +3194,13 @@ static int
vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
PCI_FUNC(vtd_as->devfn));
return -ENOTSUP;
}
+ if (!x86_iommu->dt_supported && (new & IOMMU_NOTIFIER_DEVIOTLB_UNMAP)) {
+ error_setg_errno(errp, ENOTSUP,
+ "device %02x.%02x.%x requires device IOTLB mode",
+ pci_bus_num(vtd_as->bus), PCI_SLOT(vtd_as->devfn),
+ PCI_FUNC(vtd_as->devfn));
+ return -ENOTSUP;
+ }
/* Update per-address-space notifier flags */
vtd_as->notifier_flags = new;
--
2.25.1
- [PATCH V2 0/5] Fix UNMAP notifier for intel-iommu, Jason Wang, 2023/02/23
- [PATCH V2 1/5] intel-iommu: fail MAP notifier without caching mode, Jason Wang, 2023/02/23
- [PATCH V2 2/5] intel-iommu: fail DEVIOTLB_UNMAP without dt mode,
Jason Wang <=
- [PATCH V2 3/5] memory: introduce memory_region_unmap_iommu_notifier_range(), Jason Wang, 2023/02/23
- [PATCH V2 4/5] smmu: switch to use memory_region_unmap_iommu_notifier_range(), Jason Wang, 2023/02/23
- [PATCH V2 5/5] intel-iommu: send UNMAP notifications for domain or global inv desc, Jason Wang, 2023/02/23
- Re: [PATCH V2 0/5] Fix UNMAP notifier for intel-iommu, Peter Xu, 2023/02/23