[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 1/5] intel-iommu: fail MAP notifier without caching mode
From: |
Jason Wang |
Subject: |
[PATCH V2 1/5] intel-iommu: fail MAP notifier without caching mode |
Date: |
Thu, 23 Feb 2023 14:59:20 +0800 |
Without caching mode, MAP notifier won't work correctly since guest
won't send IOTLB update event when it establishes new mappings in the
I/O page tables. Let's fail the IOMMU notifiers early instead of
misbehaving silently.
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Tested-by: Viktor Prutyanov <viktor@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/i386/intel_iommu.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 98a5c304a7..0de3e31577 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3186,6 +3186,13 @@ static int
vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
"Snoop Control with vhost or VFIO is not supported");
return -ENOTSUP;
}
+ if (!s->caching_mode && (new & IOMMU_NOTIFIER_MAP)) {
+ error_setg_errno(errp, ENOTSUP,
+ "device %02x.%02x.%x requires caching mode",
+ pci_bus_num(vtd_as->bus), PCI_SLOT(vtd_as->devfn),
+ PCI_FUNC(vtd_as->devfn));
+ return -ENOTSUP;
+ }
/* Update per-address-space notifier flags */
vtd_as->notifier_flags = new;
--
2.25.1
- [PATCH V2 0/5] Fix UNMAP notifier for intel-iommu, Jason Wang, 2023/02/23
- [PATCH V2 1/5] intel-iommu: fail MAP notifier without caching mode,
Jason Wang <=
- [PATCH V2 2/5] intel-iommu: fail DEVIOTLB_UNMAP without dt mode, Jason Wang, 2023/02/23
- [PATCH V2 3/5] memory: introduce memory_region_unmap_iommu_notifier_range(), Jason Wang, 2023/02/23
- [PATCH V2 4/5] smmu: switch to use memory_region_unmap_iommu_notifier_range(), Jason Wang, 2023/02/23
- [PATCH V2 5/5] intel-iommu: send UNMAP notifications for domain or global inv desc, Jason Wang, 2023/02/23
- Re: [PATCH V2 0/5] Fix UNMAP notifier for intel-iommu, Peter Xu, 2023/02/23