qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/12] tests: skip the nios2 replay_kernel test


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 08/12] tests: skip the nios2 replay_kernel test
Date: Wed, 22 Feb 2023 16:01:14 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 15/2/23 21:59, Richard Henderson wrote:
On 2/15/23 10:47, Philippe Mathieu-Daudé wrote:
+    @skip("nios2 emulation is buggy under record/replay")

It will be hard to notice the flakyness got improved. What about:

        @skipUnless(os.getenv('AVOCADO_RUN_FLAKY_TESTS'), 'Flaky test')

      def test_nios2_10m50(self):
          """
          :avocado: tags=arch:nios2

It'll be hard for there to be any improvement without an active maintainer.

In that case no point in keeping the test...

Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Last patch from any of the listed maintainers was:

commit ebedf0f9cd46b617df331eecc857c379d574ac62
Author: Marek Vasut <marex@denx.de>
Date:   Fri Mar 17 22:06:27 2017 +0100

     nios2: iic: Convert CPU prop to qom link

It's probably time to demote "Maintained" to "Orphan".


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]