qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage


From: Gavin Shan
Subject: Re: [PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage
Date: Wed, 22 Feb 2023 17:06:15 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0

On 2/22/23 10:58 AM, Peter Xu wrote:
On Wed, Feb 22, 2023 at 10:44:07AM +1100, Gavin Shan wrote:
Peter, could you please give some hints for me to understand the atomic
and non-atomic update here? Ok, I will drop this part of changes in next
revision with the assumption that we have atomic update supported for
ARM64.

See commit f39b7d2b96.  Please don't remove the change in this patch.

The comment was just something I thought about when reading, not something
I suggested to change.

If to remove it we'll need to remove the whole chunk not your changes alone
here.  Still, please take it with a grain of salt before anyone can help to
confirm because I can miss something else here.

In short: before we know anything solidly, your current code is exactly
correct, AFAICT.


Thanks, Peter. I think it's all for later. I will keep the changes and with
your r-b in next revision :)

Thanks,
Gavin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]