[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage
From: |
Peter Xu |
Subject: |
Re: [PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage |
Date: |
Tue, 21 Feb 2023 18:58:15 -0500 |
Hi, Gavin,
On Wed, Feb 22, 2023 at 10:44:07AM +1100, Gavin Shan wrote:
> Peter, could you please give some hints for me to understand the atomic
> and non-atomic update here? Ok, I will drop this part of changes in next
> revision with the assumption that we have atomic update supported for
> ARM64.
See commit f39b7d2b96. Please don't remove the change in this patch.
The comment was just something I thought about when reading, not something
I suggested to change.
If to remove it we'll need to remove the whole chunk not your changes alone
here. Still, please take it with a grain of salt before anyone can help to
confirm because I can miss something else here.
In short: before we know anything solidly, your current code is exactly
correct, AFAICT.
Thanks,
--
Peter Xu
- [PATCH v1 1/6] linux-headers: Update for dirty ring, (continued)
[PATCH v1 4/6] kvm: Add helper kvm_dirty_ring_init(), Gavin Shan, 2023/02/12
[PATCH v1 3/6] kvm: Synchronize the backup bitmap in the last stage, Gavin Shan, 2023/02/12
[PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring, Gavin Shan, 2023/02/12
- Re: [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring, Peter Maydell, 2023/02/21
- Re: [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring, Gavin Shan, 2023/02/21
- Re: [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring, Peter Maydell, 2023/02/22
- Re: [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring, Gavin Shan, 2023/02/22
- Re: [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring, Peter Maydell, 2023/02/23
- Re: [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring, Gavin Shan, 2023/02/24
[PATCH v1 6/6] kvm: Enable dirty ring for arm64, Gavin Shan, 2023/02/12
Re: [PATCH v1 0/6] hw/arm/virt: Support dirty ring, Zhenyu Zhang, 2023/02/16