qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] hw/cxl: rename mailbox return code type from ret_code to


From: Ira Weiny
Subject: Re: [PATCH 2/6] hw/cxl: rename mailbox return code type from ret_code to CXLRetCode
Date: Tue, 21 Feb 2023 17:47:58 -0800

Jonathan Cameron wrote:
> This enum typedef used to be local to one file, so having a generic
> name wasn't a big problem even if it wasn't compliant with QEMU naming
> conventions.  Now it is in cxl_device.h to support use outside of
> cxl-mailbox-utils.c rename it.

Same comment as 1/6 but still.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  hw/cxl/cxl-mailbox-utils.c  | 62 ++++++++++++++++++-------------------
>  include/hw/cxl/cxl_device.h |  2 +-
>  2 files changed, 32 insertions(+), 32 deletions(-)
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]