[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] hw/cxl: Move enum ret_code definition to cxl_device.h
From: |
Ira Weiny |
Subject: |
Re: [PATCH 1/6] hw/cxl: Move enum ret_code definition to cxl_device.h |
Date: |
Tue, 21 Feb 2023 17:47:23 -0800 |
Jonathan Cameron wrote:
> Needs tidy up and rename to something more generic now it is
> in a header.
I'm not opposed to this change and patch 2 but I don't see where
CXLRetCode is being used outside of cxl-mailbox-utils.c in this series.
Despite that reservation I think this is a good clarification.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> hw/cxl/cxl-mailbox-utils.c | 28 ----------------------------
> include/hw/cxl/cxl_device.h | 28 ++++++++++++++++++++++++++++
> 2 files changed, 28 insertions(+), 28 deletions(-)
>
- [PATCH 0/6] hw/cxl: Poison get, inject, clear, Jonathan Cameron, 2023/02/17
- [PATCH 1/6] hw/cxl: Move enum ret_code definition to cxl_device.h, Jonathan Cameron, 2023/02/17
- Re: [PATCH 1/6] hw/cxl: Move enum ret_code definition to cxl_device.h,
Ira Weiny <=
- [PATCH 2/6] hw/cxl: rename mailbox return code type from ret_code to CXLRetCode, Jonathan Cameron, 2023/02/17
- [PATCH 3/6] hw/cxl: Introduce cxl_device_get_timestamp() utility function, Jonathan Cameron, 2023/02/17
- [PATCH 4/6] hw/cxl: QMP based poison injection support, Jonathan Cameron, 2023/02/17
- [PATCH 5/6] hw/cxl: Add poison injection via the mailbox., Jonathan Cameron, 2023/02/17