[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/12] Q35 PCI host fixes and QOM cleanup
From: |
Bernhard Beschow |
Subject: |
Re: [PATCH 00/12] Q35 PCI host fixes and QOM cleanup |
Date: |
Tue, 21 Feb 2023 15:39:28 +0000 |
Am 14. Februar 2023 13:14:29 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>This series mostly cleans up QOM-related initialization code. It also performs
>
>some modernization and fixing.
>
>
>
>The first patch originates from "PC and ICH9 clanups" series [1] which has been
>
>dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
>
>needs more work, so bring the patch back here.
>
>
>
>Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.
>
>
>
>Patches 4-9 clean up initialization code.
>
>
>
>The last four patches also clean up initialization code with the last patch
>
>doing the actual cleanup.
>
Ping
>
>
>Based-on: <20230213162004.2797-1-shentey@gmail.com>
>
> "[PATCH v4 0/9] PC cleanups"
>
>
>
>Testing done:
>
>* `make check`
>
>* `make check-avocado`
>
>* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
>
> manjaro-kde-21.3.2-220704-linux515.iso`
>
>
>
>[1]
>https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
>
>[2]
>20230203180914.49112-1-philmd@linaro.org/">https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
>
>
>
>Bernhard Beschow (12):
>
> hw/i386/pc_q35: Resolve redundant q35_host variable
>
> hw/pci-host/q35: Fix contradicting .endianness assignment
>
> hw/pci-host/q35: Use memory_region_set_address() also for
>
> tseg_blackhole
>
> hw/pci-host/q35: Initialize PCMachineState::bus in board code
>
> hw/pci-host/q35: Initialize "bypass-iommu" property from board code
>
> hw/pci-host/q35: Initialize properties just once
>
> hw/pci-host/q35: Initialize PCI hole boundaries just once
>
> hw/pci-host/q35: Turn PCI hole properties into class properties
>
> hw/pci-host/q35: Rename local variable to more idiomatic "phb"
>
> hw/pci-host/q35: Propagate to errp rather than doing error_fatal
>
> hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
>
> hw/pci-host/q35: Move MemoryRegion pointers to host device
>
>
>
> include/hw/pci-host/q35.h | 17 +-
>
> hw/i386/pc_q35.c | 33 ++--
>
> hw/pci-host/q35.c | 325 ++++++++++++++++++--------------------
>
> 3 files changed, 178 insertions(+), 197 deletions(-)
>
>
>
>-- >
>2.39.1
>
>
>
- [PATCH 04/12] hw/pci-host/q35: Initialize PCMachineState::bus in board code, (continued)
- [PATCH 04/12] hw/pci-host/q35: Initialize PCMachineState::bus in board code, Bernhard Beschow, 2023/02/14
- [PATCH 05/12] hw/pci-host/q35: Initialize "bypass-iommu" property from board code, Bernhard Beschow, 2023/02/14
- [PATCH 06/12] hw/pci-host/q35: Initialize properties just once, Bernhard Beschow, 2023/02/14
- [PATCH 10/12] hw/pci-host/q35: Propagate to errp rather than doing error_fatal, Bernhard Beschow, 2023/02/14
- [PATCH 09/12] hw/pci-host/q35: Rename local variable to more idiomatic "phb", Bernhard Beschow, 2023/02/14
- [PATCH 11/12] hw/pci-host/q35: Merge mch_realize() into q35_host_realize(), Bernhard Beschow, 2023/02/14
- [PATCH 02/12] hw/pci-host/q35: Fix contradicting .endianness assignment, Bernhard Beschow, 2023/02/14
- [PATCH 07/12] hw/pci-host/q35: Initialize PCI hole boundaries just once, Bernhard Beschow, 2023/02/14
- [PATCH 08/12] hw/pci-host/q35: Turn PCI hole properties into class properties, Bernhard Beschow, 2023/02/14
- [PATCH 12/12] hw/pci-host/q35: Move MemoryRegion pointers to host device, Bernhard Beschow, 2023/02/14
- Re: [PATCH 00/12] Q35 PCI host fixes and QOM cleanup,
Bernhard Beschow <=