[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/12] hw/pci-host/q35: Propagate to errp rather than doing error
From: |
Bernhard Beschow |
Subject: |
[PATCH 10/12] hw/pci-host/q35: Propagate to errp rather than doing error_fatal |
Date: |
Tue, 14 Feb 2023 14:14:39 +0100 |
q35_host_realize() has an errp parameter. Use that to be able to
propagate the error instead of terminating abruptly.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/pci-host/q35.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 8f81debfa5..d517f5622b 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -46,6 +46,7 @@
static void q35_host_realize(DeviceState *dev, Error **errp)
{
+ ERRP_GUARD();
Q35PCIHost *s = Q35_HOST_DEVICE(dev);
PCIHostState *phb = PCI_HOST_BRIDGE(dev);
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
@@ -74,7 +75,7 @@ static void q35_host_realize(DeviceState *dev, Error **errp)
s->mch.address_space_io,
0, TYPE_PCIE_BUS);
- qdev_realize(DEVICE(&s->mch), BUS(phb->bus), &error_fatal);
+ qdev_realize(DEVICE(&s->mch), BUS(phb->bus), errp);
}
static const char *q35_host_root_bus_path(PCIHostState *host_bridge,
--
2.39.1
- [PATCH 00/12] Q35 PCI host fixes and QOM cleanup, Bernhard Beschow, 2023/02/14
- [PATCH 01/12] hw/i386/pc_q35: Resolve redundant q35_host variable, Bernhard Beschow, 2023/02/14
- [PATCH 03/12] hw/pci-host/q35: Use memory_region_set_address() also for tseg_blackhole, Bernhard Beschow, 2023/02/14
- [PATCH 04/12] hw/pci-host/q35: Initialize PCMachineState::bus in board code, Bernhard Beschow, 2023/02/14
- [PATCH 05/12] hw/pci-host/q35: Initialize "bypass-iommu" property from board code, Bernhard Beschow, 2023/02/14
- [PATCH 06/12] hw/pci-host/q35: Initialize properties just once, Bernhard Beschow, 2023/02/14
- [PATCH 10/12] hw/pci-host/q35: Propagate to errp rather than doing error_fatal,
Bernhard Beschow <=
- [PATCH 09/12] hw/pci-host/q35: Rename local variable to more idiomatic "phb", Bernhard Beschow, 2023/02/14
- [PATCH 11/12] hw/pci-host/q35: Merge mch_realize() into q35_host_realize(), Bernhard Beschow, 2023/02/14
- [PATCH 02/12] hw/pci-host/q35: Fix contradicting .endianness assignment, Bernhard Beschow, 2023/02/14
- [PATCH 07/12] hw/pci-host/q35: Initialize PCI hole boundaries just once, Bernhard Beschow, 2023/02/14
- [PATCH 08/12] hw/pci-host/q35: Turn PCI hole properties into class properties, Bernhard Beschow, 2023/02/14
- [PATCH 12/12] hw/pci-host/q35: Move MemoryRegion pointers to host device, Bernhard Beschow, 2023/02/14
- Re: [PATCH 00/12] Q35 PCI host fixes and QOM cleanup, Bernhard Beschow, 2023/02/21