[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 23/27] target/s390x: Remove PER check from use_goto_tb
From: |
Richard Henderson |
Subject: |
[PATCH v4 23/27] target/s390x: Remove PER check from use_goto_tb |
Date: |
Mon, 20 Feb 2023 08:40:48 -1000 |
While it is common for the PC update to happen in the
shadow of a goto_tb, it is not required to be there.
By moving it before the goto_tb, we can also place the
call to helper_per_branch there, and then afterward
chain to the next tb.
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 8fbbbf8bbd..24d8d84727 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -669,9 +669,6 @@ static void gen_op_calc_cc(DisasContext *s)
static bool use_goto_tb(DisasContext *s, uint64_t dest)
{
- if (per_enabled(s)) {
- return false;
- }
return translator_use_goto_tb(&s->base, dest);
}
@@ -1173,15 +1170,16 @@ static DisasJumpType help_goto_direct(DisasContext *s,
int64_t disp)
per_branch_disp(s, disp);
return DISAS_NEXT;
}
+
+ update_psw_addr_disp(s, disp);
+ per_branch_dest(s, psw_addr);
+
if (use_goto_tb(s, s->base.pc_next + disp)) {
update_cc_op(s);
tcg_gen_goto_tb(0);
- update_psw_addr_disp(s, disp);
tcg_gen_exit_tb(s->base.tb, 0);
return DISAS_NORETURN;
} else {
- update_psw_addr_disp(s, disp);
- per_branch_dest(s, psw_addr);
return DISAS_PC_UPDATED;
}
}
--
2.34.1
- [PATCH v4 10/27] target/s390x: Use gen_psw_addr_disp in pc_to_link_info, (continued)
- [PATCH v4 10/27] target/s390x: Use gen_psw_addr_disp in pc_to_link_info, Richard Henderson, 2023/02/20
- [PATCH v4 07/27] target/s390x: Change help_goto_direct to work on displacements, Richard Henderson, 2023/02/20
- [PATCH v4 04/27] target/s390x: Use tcg_constant_* in translate_vx.c.inc, Richard Henderson, 2023/02/20
- [PATCH v4 20/27] target/s390x: Split per_branch, Richard Henderson, 2023/02/20
- [PATCH v4 25/27] tests/tcg/s390x: Add per.S, Richard Henderson, 2023/02/20
- [PATCH v4 14/27] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state, Richard Henderson, 2023/02/20
- [PATCH v4 09/27] target/s390x: Remove pc argument to pc_to_link_into, Richard Henderson, 2023/02/20
- [PATCH v4 05/27] tests/tcg/s390x: Add bal.S, Richard Henderson, 2023/02/20
- [PATCH v4 15/27] target/s390x: Add disp argument to update_psw_addr, Richard Henderson, 2023/02/20
- [PATCH v4 21/27] target/s390x: Simplify help_branch, Richard Henderson, 2023/02/20
- [PATCH v4 23/27] target/s390x: Remove PER check from use_goto_tb,
Richard Henderson <=
- [PATCH v4 24/27] target/s390x: Fix successful-branch PER events, Richard Henderson, 2023/02/20
- [PATCH v4 27/27] target/s390x: Enable TARGET_TB_PCREL, Richard Henderson, 2023/02/20
- [PATCH v4 16/27] target/s390x: Don't set gbea for user-only, Richard Henderson, 2023/02/20
- [PATCH v4 17/27] target/s390x: Introduce per_enabled, Richard Henderson, 2023/02/20
- [PATCH v4 18/27] target/s390x: Disable conditional branch-to-next for PER, Richard Henderson, 2023/02/20
- [PATCH v4 19/27] target/s390x: Introduce help_goto_indirect, Richard Henderson, 2023/02/20
- [PATCH v4 22/27] target/s390x: Split per_breaking_event from per_branch_*, Richard Henderson, 2023/02/20