[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 07/27] target/s390x: Change help_goto_direct to work on displa
From: |
Richard Henderson |
Subject: |
[PATCH v4 07/27] target/s390x: Change help_goto_direct to work on displacements |
Date: |
Mon, 20 Feb 2023 08:40:32 -1000 |
In preparation for TARGET_TB_PCREL, reduce reliance on absolute values.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index faa6f737ba..bd7f644f83 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -1161,8 +1161,10 @@ struct DisasInsn {
/* ====================================================================== */
/* Miscellaneous helpers, used by several operations. */
-static DisasJumpType help_goto_direct(DisasContext *s, uint64_t dest)
+static DisasJumpType help_goto_direct(DisasContext *s, int64_t disp)
{
+ uint64_t dest = s->base.pc_next + disp;
+
if (dest == s->pc_tmp) {
per_branch(s, true);
return DISAS_NEXT;
@@ -1185,7 +1187,8 @@ static DisasJumpType help_branch(DisasContext *s,
DisasCompare *c,
bool is_imm, int imm, TCGv_i64 cdest)
{
DisasJumpType ret;
- uint64_t dest = s->base.pc_next + (int64_t)imm * 2;
+ int64_t disp = (int64_t)imm * 2;
+ uint64_t dest = s->base.pc_next + disp;
TCGLabel *lab;
/* Take care of the special cases first. */
@@ -1201,7 +1204,7 @@ static DisasJumpType help_branch(DisasContext *s,
DisasCompare *c,
goto egress;
}
if (c->cond == TCG_COND_ALWAYS) {
- ret = help_goto_direct(s, dest);
+ ret = help_goto_direct(s, disp);
goto egress;
}
} else {
@@ -1573,7 +1576,7 @@ static DisasJumpType op_bal(DisasContext *s, DisasOps *o)
static DisasJumpType op_basi(DisasContext *s, DisasOps *o)
{
pc_to_link_info(o->out, s, s->pc_tmp);
- return help_goto_direct(s, s->base.pc_next + (int64_t)get_field(s, i2) *
2);
+ return help_goto_direct(s, (int64_t)get_field(s, i2) * 2);
}
static DisasJumpType op_bc(DisasContext *s, DisasOps *o)
--
2.34.1
- [PATCH v4 00/27] target/s390x: pc-relative translation blocks, Richard Henderson, 2023/02/20
- [PATCH v4 06/27] tests/tcg/s390x: Add sam.S, Richard Henderson, 2023/02/20
- [PATCH v4 12/27] target/s390x: Use gen_psw_addr_disp in op_sam, Richard Henderson, 2023/02/20
- [PATCH v4 02/27] target/s390x: Use tcg_constant_* for DisasCompare, Richard Henderson, 2023/02/20
- [PATCH v4 03/27] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34, Richard Henderson, 2023/02/20
- [PATCH v4 13/27] target/s390x: Use ilen instead in branches, Richard Henderson, 2023/02/20
- [PATCH v4 01/27] target/s390x: Use tcg_constant_* in local contexts, Richard Henderson, 2023/02/20
- [PATCH v4 11/27] target/s390x: Use gen_psw_addr_disp in save_link_info, Richard Henderson, 2023/02/20
- [PATCH v4 08/27] target/s390x: Introduce gen_psw_addr_disp, Richard Henderson, 2023/02/20
- [PATCH v4 10/27] target/s390x: Use gen_psw_addr_disp in pc_to_link_info, Richard Henderson, 2023/02/20
- [PATCH v4 07/27] target/s390x: Change help_goto_direct to work on displacements,
Richard Henderson <=
- [PATCH v4 04/27] target/s390x: Use tcg_constant_* in translate_vx.c.inc, Richard Henderson, 2023/02/20
- [PATCH v4 20/27] target/s390x: Split per_branch, Richard Henderson, 2023/02/20
- [PATCH v4 25/27] tests/tcg/s390x: Add per.S, Richard Henderson, 2023/02/20
- [PATCH v4 14/27] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state, Richard Henderson, 2023/02/20
- [PATCH v4 09/27] target/s390x: Remove pc argument to pc_to_link_into, Richard Henderson, 2023/02/20
- [PATCH v4 05/27] tests/tcg/s390x: Add bal.S, Richard Henderson, 2023/02/20
- [PATCH v4 15/27] target/s390x: Add disp argument to update_psw_addr, Richard Henderson, 2023/02/20
- [PATCH v4 21/27] target/s390x: Simplify help_branch, Richard Henderson, 2023/02/20
- [PATCH v4 23/27] target/s390x: Remove PER check from use_goto_tb, Richard Henderson, 2023/02/20
- [PATCH v4 24/27] target/s390x: Fix successful-branch PER events, Richard Henderson, 2023/02/20