Re: [PULL v2 0/10] xenpvh

[Peter Maydell]

On Thu, 16 Feb 2023 at 12:59, Fabiano Rosas <farosas@suse.de> wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
> > On Tue, 14 Feb 2023 at 23:43, Stefano Stabellini <sstabellini@kernel.org> 
> > wrote:
> >>
> >> The following changes since commit 
> >> 6a50f64ca01d0a7b97f14f069762bfd88160f31e:
> >>
> >>   Merge tag 'pull-request-2023-02-14' of https://gitlab.com/thuth/qemu 
> >> into staging (2023-02-14 14:46:10 +0000)
> >>
> >> are available in the Git repository at:
> >>
> >>   https://gitlab.com/sstabellini/qemu xenpvh2
> >>
> >> for you to fetch changes up to 86b01d58ca2840bea6e4e7260aad450a660fbd46:
> >>
> >>   meson.build: enable xenpv machine build for ARM (2023-02-14 15:39:25 
> >> -0800)
> >>
> >> ----------------------------------------------------------------
> >
> > Fails to compile for some configs, eg:
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/3775820949
> > https://gitlab.com/qemu-project/qemu/-/jobs/3775820984
> >
> > In file included from ../target/arm/machine.c:6:
> > ../target/arm/internals.h:1141:21: error: field ‘f’ has incomplete type
> > 1141 | CPUTLBEntryFull f;
> >
> >
> > This job fails in 'make check':
> > https://gitlab.com/qemu-project/qemu/-/jobs/3775821028
> >
> > qemu-system-aarch64: The -accel and "-machine accel=" options are 
> > incompatible
>
> Here the issue is that we have:
>
> mc->default_machine_opts = "accel=xen";
>
> which conflicts with -accel qtest added by the tests.

I'm inclined to say that machines should not specify an
accelerator type. Leave that to the user, and produce an
error if it's not one that will work. (Note that 'qtest'
must work, because it's part of 'make check' testing that
every board can be created.)

thanks
-- PMM