Re: [PULL v2 0/10] xenpvh

[Peter Maydell]

On Wed, 15 Feb 2023 at 21:17, Stefano Stabellini <sstabellini@kernel.org> wrote:
>
> On Wed, 15 Feb 2023, Fabiano Rosas wrote:
> > Peter Maydell <peter.maydell@linaro.org> writes:
> >
> > > On Tue, 14 Feb 2023 at 23:43, Stefano Stabellini <sstabellini@kernel.org> 
> > > wrote:
> > >>
> > >> The following changes since commit 
> > >> 6a50f64ca01d0a7b97f14f069762bfd88160f31e:
> > >>
> > >>   Merge tag 'pull-request-2023-02-14' of https://gitlab.com/thuth/qemu 
> > >> into staging (2023-02-14 14:46:10 +0000)
> > >>
> > >> are available in the Git repository at:
> > >>
> > >>   https://gitlab.com/sstabellini/qemu xenpvh2
> > >>
> > >> for you to fetch changes up to 86b01d58ca2840bea6e4e7260aad450a660fbd46:
> > >>
> > >>   meson.build: enable xenpv machine build for ARM (2023-02-14 15:39:25 
> > >> -0800)
> > >>
> > >> ----------------------------------------------------------------
> > >
> > > Fails to compile for some configs, eg:
> > >
> > > https://gitlab.com/qemu-project/qemu/-/jobs/3775820949
> > > https://gitlab.com/qemu-project/qemu/-/jobs/3775820984
> > >
> > > In file included from ../target/arm/machine.c:6:
> > > ../target/arm/internals.h:1141:21: error: field ‘f’ has incomplete type
> > > 1141 | CPUTLBEntryFull f;
> > >
> >
> > For this to work we'll probably need to cherry-pick some parts of my
> > disable-tcg series:
> >
> > 20230213202927.28992-1-farosas@suse.de">https://lore.kernel.org/r/20230213202927.28992-1-farosas@suse.de
> >
> > For this error specifically, patch 16.
>
> Thanks for the quick reply!
>
> Peter, how would you like to proceed? Vikram (the original contributor)
> will be AFK for a few weeks but I might be able to have a look this in
> the meantime. But if this is a known issue with already a fix available,
> then what should be the action for me?

You need to submit a pullreq which applies to current head-of-git.
If it depends on other patches, then if those are reviewed then
you can include them. In this case patch 16 of Fabiano's series
looks OK to include, assuming that's the only thing you need.

(But other stuff in that patchseries may be rather trickier to
extract from it.)

Make sure you test the xen-only build config in case there's
something else.

thanks
-- PMM