Re: [PATCH RESEND v5 07/28] target/arm: Move define_debug_regs() to cpregs.c

[Peter Maydell]

On Mon, 13 Feb 2023 at 20:31, Fabiano Rosas <farosas@suse.de> wrote:
>
> The debug_helper.c file will move into a tcg-specific directory, so
> take the cpregs code out of it. That code needs to be present in KVM
> builds as well.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/arm/cpregs.c       | 473 ++++++++++++++++++++++++++++++++++++++
>  target/arm/debug_helper.c | 459 ------------------------------------
>  target/arm/internals.h    |   9 -
>  3 files changed, 473 insertions(+), 468 deletions(-)

I definitely think this is not an improvement. Currently we
have a file debug_helper.c with a reasonably well defined
purpose (debug related cpregs and code). This patch moves
half of that into the already massively too large cpregs.c,
thus undoing the cleanup we did by separating out the debug
register code from the huge pile of code in helper.c.

thanks
-- PMM