[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 03/16] hw/arm/smmuv3: Rename smmu_ptw_64
From: |
Mostafa Saleh |
Subject: |
Re: [RFC PATCH 03/16] hw/arm/smmuv3: Rename smmu_ptw_64 |
Date: |
Thu, 16 Feb 2023 12:56:17 +0000 |
On Wed, Feb 15, 2023 at 05:53:23PM +0100, Eric Auger wrote:
> > + SMMUTLBEntry *tlbe, SMMUPTWEventInfo *info)
> > {
> > dma_addr_t baseaddr, indexmask;
> > int stage = cfg->stage;
> > @@ -384,7 +384,7 @@ int smmu_ptw(SMMUTransCfg *cfg, dma_addr_t iova,
> > IOMMUAccessFlags perm,
> > g_assert_not_reached();
> > }
> >
> > - return smmu_ptw_64(cfg, iova, perm, tlbe, info);
> > + return smmu_ptw_64_s1(cfg, iova, perm, tlbe, info);
> May need to rename the trace points as well
>
All PTW trace points have a stage argument which is set correctly
from stage-1/stage-2 ptw functions:
trace_smmu_ptw_page_pte
trace_smmu_ptw_block_pte
trace_smmu_ptw_invalid_pte
trace_smmu_ptw_level is the only one that had no stage argument, I can
change it to be consistent with the others.
Thanks,
Mostafa
[RFC PATCH 05/16] hw/arm/smmuv3: Add page table walk for stage-2, Mostafa Saleh, 2023/02/05
[RFC PATCH 06/16] hw/arm/smmuv3: Parse STE config for stage-2, Mostafa Saleh, 2023/02/05