Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

[Daniel P . Berrangé]

On Wed, Feb 15, 2023 at 04:33:42PM +0100, Thomas Huth wrote:
> On 15/02/2023 15.58, Daniel P. Berrangé wrote:
> > On Wed, Feb 15, 2023 at 03:25:03PM +0100, Thomas Huth wrote:
> > > The meson log files can get very big, especially if running the tests in
> > > verbose mode. So dumping those logs to the console was a bad idea, since
> > > gitlab truncates the output if it is getting too big. Let's publish the
> > > logs as artifacts instead. This has the disadvantage that you have to
> > > look up the logs on cirrus-ci.com now instead, but that's still better
> > > than not having the important part of the log at all since it got
> > > truncated.
> > 
> > Having to go over to cirrus-ci.com is pretty awful user experiance,
> > especially as there's no direct link.
> 
> It's not that bad, see e.g.:
> 
>  https://gitlab.com/thuth/qemu/-/jobs/3775523498
> 
> The log shows a link to cirrus-ci.com at the end:
> 
>  Build failed: https://cirrus-ci.com/build/4811273133621248
> 
> If you click on that URL, you've just got to go into the "build" and click
> through the build artifacts to get to the log that you want.
> 
> > > +      type: text/plain
> > 
> > Does it have to be either/or, can't we do both ?
> > 
> > 95% of the time the truncated testlog.txt is sufficient on its own.
> 
> I'd say 95% of the time the normal console output (without the "cat
> .../testlog.txt") is already enough since meson prints the stdout and stderr
> of the failing tests to the console already.
> 
> FWIW, this is the test run with the truncated output that Peter complained
> about earlier today in IRC:
> 
>  https://gitlab.com/qemu-project/qemu/-/jobs/3768540680
> 
> Even if you click on the "complete raw" link there, you'll have a hard time
> finding the information that you are interested in. So I'd really prefer to
> not dump testlog.txt by default and only have it via the artifacts instead.

Ok, you convinced me.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|