Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

[Daniel P . Berrangé]

On Wed, Feb 15, 2023 at 03:25:03PM +0100, Thomas Huth wrote:
> The meson log files can get very big, especially if running the tests in
> verbose mode. So dumping those logs to the console was a bad idea, since
> gitlab truncates the output if it is getting too big. Let's publish the
> logs as artifacts instead. This has the disadvantage that you have to
> look up the logs on cirrus-ci.com now instead, but that's still better
> than not having the important part of the log at all since it got
> truncated.

Having to go over to cirrus-ci.com is pretty awful user experiance,
especially as there's no direct link.

> Fixes: 998f334722 ("gitlab: show testlog.txt contents ...")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Note: I also tried to publish the junit xml files as artifacts
>  instead, but while the cirrus-ci docs claim to support it, I only
>  got unreadable XML output in my browser that way, so the .txt
>  files look like the better option to me.
> 
>  .gitlab-ci.d/cirrus/build.yml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
> index 7ef6af8d33..a9444902ec 100644
> --- a/.gitlab-ci.d/cirrus/build.yml
> +++ b/.gitlab-ci.d/cirrus/build.yml
> @@ -32,6 +32,9 @@ build_task:
>      - $MAKE -j$(sysctl -n hw.ncpu)
>      - for TARGET in $TEST_TARGETS ;
>        do
> -        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1
> -        || { cat meson-logs/testlog.txt; exit 1; } ;
> +        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1 ;
>        done
> +  always:
> +    build_result_artifacts:
> +      path: build/meson-logs/*log.txt
> +      type: text/plain

Does it have to be either/or, can't we do both ?

95% of the time the truncated testlog.txt is sufficient on its own.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|