[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 08/16] python/machine.py: upgrade vm.cmd() method
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v5 08/16] python/machine.py: upgrade vm.cmd() method |
Date: |
Wed, 15 Feb 2023 16:25:39 +0300 |
The method is not popular in iotests, we prefer use vm.qmp() and then
check success by hand.. But that's not optimal. To simplify movement to
vm.cmd() let's support same interface improvements like in vm.qmp().
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
python/qemu/machine/machine.py | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index 3b01607769..17be82e709 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -689,13 +689,23 @@ def qmp(self, cmd: str,
return ret
def cmd(self, cmd: str,
- conv_keys: bool = True,
+ args_dict: Optional[Dict[str, object]] = None,
+ conv_keys: Optional[bool] = None,
**args: Any) -> QMPReturnValue:
"""
Invoke a QMP command.
On success return the response dict.
On failure raise an exception.
"""
+ if args_dict is not None:
+ assert not args
+ assert conv_keys is None
+ args = args_dict
+ conv_keys = False
+
+ if conv_keys is None:
+ conv_keys = True
+
qmp_args = self._qmp_args(conv_keys, args)
ret = self._qmp.cmd(cmd, **qmp_args)
if cmd == 'quit':
--
2.34.1
- [PATCH v5 00/16] iotests: use vm.cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 01/16] python: fix superfluous-parens pylint error, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 03/16] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 04/16] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 02/16] python: fix broad-exception-raised pylint error, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 06/16] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 08/16] python/machine.py: upgrade vm.cmd() method,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v5 05/16] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 07/16] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 09/16] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine., Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 10/16] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 12/16] iotests: drop some occasional semicolons, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 14/16] iotests.py: pause_job(): drop return value, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 11/16] iotests: refactor some common qmp result checks into generic pattern, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 13/16] iotests: drop some extra ** in qmp() call, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 15/16] tests/vm/basevm.py: use cmd() instead of qmp(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 16/16] python: use vm.cmd() instead of vm.qmp() where appropriate, Vladimir Sementsov-Ogievskiy, 2023/02/15