[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 06/16] python: rename QEMUMonitorProtocol.cmd() to cmd_raw()
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v5 06/16] python: rename QEMUMonitorProtocol.cmd() to cmd_raw() |
Date: |
Wed, 15 Feb 2023 16:25:37 +0300 |
Having cmd() and command() methods in one class doesn't look good.
Rename cmd() to cmd_raw(), to show its meaning better.
We also want to rename command() to cmd() in future, so this commit is
a necessary step.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
python/qemu/machine/machine.py | 2 +-
python/qemu/qmp/legacy.py | 4 ++--
tests/qemu-iotests/iotests.py | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index e57c254484..0428eec50c 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -683,7 +683,7 @@ def qmp(self, cmd: str,
conv_keys = True
qmp_args = self._qmp_args(conv_keys, args)
- ret = self._qmp.cmd(cmd, args=qmp_args)
+ ret = self._qmp.cmd_raw(cmd, args=qmp_args)
if cmd == 'quit' and 'error' not in ret and 'return' in ret:
self._quit_issued = True
return ret
diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
index c7b252842a..5552f4ebb4 100644
--- a/python/qemu/qmp/legacy.py
+++ b/python/qemu/qmp/legacy.py
@@ -198,8 +198,8 @@ def cmd_obj(self, qmp_cmd: QMPMessage) -> QMPMessage:
)
)
- def cmd(self, name: str,
- args: Optional[Dict[str, object]] = None) -> QMPMessage:
+ def cmd_raw(self, name: str,
+ args: Optional[Dict[str, object]] = None) -> QMPMessage:
"""
Build a QMP command and send it to the QMP Monitor.
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 3e82c634cf..675fbaa1c3 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -460,7 +460,7 @@ def __init__(self, *args: str, instance_id: str = 'a', qmp:
bool = False):
def qmp(self, cmd: str, args: Optional[Dict[str, object]] = None) \
-> QMPMessage:
assert self._qmp is not None
- return self._qmp.cmd(cmd, args)
+ return self._qmp.cmd_raw(cmd, args)
def stop(self, kill_signal=15):
self._p.send_signal(kill_signal)
--
2.34.1
- [PATCH v5 00/16] iotests: use vm.cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 01/16] python: fix superfluous-parens pylint error, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 03/16] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 04/16] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 02/16] python: fix broad-exception-raised pylint error, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 06/16] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(),
Vladimir Sementsov-Ogievskiy <=
- [PATCH v5 08/16] python/machine.py: upgrade vm.cmd() method, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 05/16] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 07/16] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 09/16] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine., Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 10/16] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 12/16] iotests: drop some occasional semicolons, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 14/16] iotests.py: pause_job(): drop return value, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 11/16] iotests: refactor some common qmp result checks into generic pattern, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 13/16] iotests: drop some extra ** in qmp() call, Vladimir Sementsov-Ogievskiy, 2023/02/15
- [PATCH v5 15/16] tests/vm/basevm.py: use cmd() instead of qmp(), Vladimir Sementsov-Ogievskiy, 2023/02/15