Re: [PATCH v1] Adding new machine Yosemitev2 in QEMU

[karthikeyan Pasupathi]

Ok, will do that.

On Tue, Feb 14, 2023 at 12:35 PM Cédric Le Goater <clg@kaod.org> wrote:

Hello,

[ adding the lists ]

>      > +static void fb_bmc_i2c_init(AspeedMachineState *bmc)
>
>     The same routine name is proposed in the tiogapass patch :
>
>     20230210122641.837614-1-pkarthikeyan1509@gmail.com/" rel="noreferrer" target="_blank">https://lore.kernel.org/qemu-devel/20230210122641.837614-1-pkarthikeyan1509@gmail.com/ <20230210122641.837614-1-pkarthikeyan1509@gmail.com/" rel="noreferrer" target="_blank">https://lore.kernel.org/qemu-devel/20230210122641.837614-1-pkarthikeyan1509@gmail.com/>
>
>     Do you have plans to populate the I2C buses differently ?
>
>
> This is an initial patch we have been working on adding more specific configurations in the future.

OK. Then please rename the routine with a "yosemite" like prefix.

Thanks,

C.