[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] Adding new machine Yosemitev2 in QEMU
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [PATCH v1] Adding new machine Yosemitev2 in QEMU |
|
Date: |
Tue, 14 Feb 2023 08:05:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 |
Hello,
[ adding the lists ]
> +static void fb_bmc_i2c_init(AspeedMachineState *bmc)
The same routine name is proposed in the tiogapass patch :
20230210122641.837614-1-pkarthikeyan1509@gmail.com/">https://lore.kernel.org/qemu-devel/20230210122641.837614-1-pkarthikeyan1509@gmail.com/
<20230210122641.837614-1-pkarthikeyan1509@gmail.com/">https://lore.kernel.org/qemu-devel/20230210122641.837614-1-pkarthikeyan1509@gmail.com/>
Do you have plans to populate the I2C buses differently ?
This is an initial patch we have been working on adding more specific
configurations in the future.
OK. Then please rename the routine with a "yosemite" like prefix.
Thanks,
C.