[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 09/14] target/arm: Simplify iteration over bit widths
From: |
Richard Henderson |
Subject: |
[PATCH 09/14] target/arm: Simplify iteration over bit widths |
Date: |
Tue, 14 Feb 2023 06:30:43 -1000 |
Order suf[] by the log8 of the width.
Use ARRAY_SIZE instead of hard-coding 128.
This changes the order of the union definitions,
but retains the order of the union-of-union members.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/gdbstub64.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c
index 166cb288cd..a6a8e7eb40 100644
--- a/target/arm/gdbstub64.c
+++ b/target/arm/gdbstub64.c
@@ -240,8 +240,8 @@ static void output_vector_union_type(GString *s, int
reg_width,
{ "int8", 8, 'b', 's' },
};
- static const char suf[] = { 'q', 'd', 's', 'h', 'b' };
- int i, j, bits;
+ static const char suf[] = { 'b', 'h', 's', 'd', 'q' };
+ int i, j;
/* First define types and totals in a whole VL */
for (i = 0; i < ARRAY_SIZE(vec_lanes); i++) {
@@ -256,7 +256,9 @@ static void output_vector_union_type(GString *s, int
reg_width,
* signed and potentially float versions of each size from 128 to
* 8 bits.
*/
- for (bits = 128, i = 0; bits >= 8; bits /= 2, i++) {
+ for (i = 0; i < ARRAY_SIZE(suf); i++) {
+ int bits = 8 << i;
+
g_string_append_printf(s, "<union id=\"%sn%c\">", name, suf[i]);
for (j = 0; j < ARRAY_SIZE(vec_lanes); j++) {
if (vec_lanes[j].size == bits) {
@@ -270,7 +272,7 @@ static void output_vector_union_type(GString *s, int
reg_width,
/* And now the final union of unions */
g_string_append_printf(s, "<union id=\"%s\">", name);
- for (bits = 128, i = 0; bits >= 8; bits /= 2, i++) {
+ for (i = ARRAY_SIZE(suf) - 1; i >= 0; i--) {
g_string_append_printf(s, "<field name=\"%c\" type=\"%sn%c\"/>",
suf[i], name, suf[i]);
}
--
2.34.1
- [PATCH 06/14] target/arm: Hoist pred_width in arm_gen_dynamic_svereg_xml, (continued)
- [PATCH 06/14] target/arm: Hoist pred_width in arm_gen_dynamic_svereg_xml, Richard Henderson, 2023/02/14
- [PATCH 11/14] target/arm: Implement gdbstub pauth extension, Richard Henderson, 2023/02/14
- [PATCH 13/14] target/arm: Export arm_v7m_get_sp_ptr, Richard Henderson, 2023/02/14
- [PATCH 12/14] target/arm: Export arm_v7m_mrs_control, Richard Henderson, 2023/02/14
- [PATCH 08/14] target/arm: Add name argument to output_vector_union_type, Richard Henderson, 2023/02/14
- [PATCH 09/14] target/arm: Simplify iteration over bit widths,
Richard Henderson <=
- [PATCH 14/14] target/arm: Support reading m-profile system registers from gdb, Richard Henderson, 2023/02/14