[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 06/12] tests/qtest: Fix coding style in device-plug-test.c
From: |
Fabiano Rosas |
Subject: |
[PATCH v3 06/12] tests/qtest: Fix coding style in device-plug-test.c |
Date: |
Mon, 13 Feb 2023 18:07:32 -0300 |
We should not mix declarations and statements in QEMU code.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/device-plug-test.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c
index 5a6afa2b57..4f92617335 100644
--- a/tests/qtest/device-plug-test.c
+++ b/tests/qtest/device-plug-test.c
@@ -64,6 +64,7 @@ static void process_device_remove(QTestState *qtest, const
char *id)
static void test_pci_unplug_request(void)
{
+ QTestState *qtest;
const char *arch = qtest_get_arch();
const char *machine_addition = "";
@@ -71,8 +72,8 @@ static void test_pci_unplug_request(void)
machine_addition = "-machine pc";
}
- QTestState *qtest = qtest_initf("%s -device virtio-mouse-pci,id=dev0",
- machine_addition);
+ qtest = qtest_initf("%s -device virtio-mouse-pci,id=dev0",
+ machine_addition);
process_device_remove(qtest, "dev0");
@@ -94,6 +95,7 @@ static void test_q35_pci_unplug_request(void)
static void test_pci_unplug_json_request(void)
{
+ QTestState *qtest;
const char *arch = qtest_get_arch();
const char *machine_addition = "";
@@ -101,7 +103,7 @@ static void test_pci_unplug_json_request(void)
machine_addition = "-machine pc";
}
- QTestState *qtest = qtest_initf(
+ qtest = qtest_initf(
"%s -device \"{'driver': 'virtio-mouse-pci', 'id': 'dev0'}\"",
machine_addition);
--
2.35.3
- [PATCH v3 00/12] qtests vs. default devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 01/12] tests/qtest: Skip PXE tests for missing devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 02/12] tests/qtest: Do not run lsi53c895a test if device is not present, Fabiano Rosas, 2023/02/13
- [PATCH v3 03/12] tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c, Fabiano Rosas, 2023/02/13
- [PATCH v3 05/12] tests/qtest: hd-geo-test: Check for missing devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 04/12] tests/qtest: Don't build virtio-serial-test.c if device not present, Fabiano Rosas, 2023/02/13
- [PATCH v3 06/12] tests/qtest: Fix coding style in device-plug-test.c,
Fabiano Rosas <=
- [PATCH v3 07/12] tests/qtest: Skip unplug tests that use missing devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 08/12] tests/qtest: drive_del-test: Skip tests that require missing devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 09/12] tests/qtest: Check for devices in bios-tables-test, Fabiano Rosas, 2023/02/13
- [PATCH v3 10/12] tests/qtest: Do not include hexloader-test if loader device is not present, Fabiano Rosas, 2023/02/13
- [PATCH v3 11/12] tests/qemu-iotests: Require virtio-scsi-pci, Fabiano Rosas, 2023/02/13
- [PATCH v3 12/12] tests/qtest: bios-tables-test: Skip if missing configs, Fabiano Rosas, 2023/02/13