[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 05/12] tests/qtest: hd-geo-test: Check for missing devices
From: |
Fabiano Rosas |
Subject: |
[PATCH v3 05/12] tests/qtest: hd-geo-test: Check for missing devices |
Date: |
Mon, 13 Feb 2023 18:07:31 -0300 |
Don't include tests that require devices not available in the QEMU
binary.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/hd-geo-test.c | 38 +++++++++++++++++++++++++-------------
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c
index 4a7628077b..5aa258a2b3 100644
--- a/tests/qtest/hd-geo-test.c
+++ b/tests/qtest/hd-geo-test.c
@@ -1090,30 +1090,42 @@ int main(int argc, char **argv)
qtest_add_func("hd-geo/override/ide", test_override_ide);
if (qtest_has_device("lsi53c895a")) {
qtest_add_func("hd-geo/override/scsi", test_override_scsi);
- qtest_add_func("hd-geo/override/scsi_2_controllers",
- test_override_scsi_2_controllers);
+ if (qtest_has_device("virtio-scsi-pci")) {
+ qtest_add_func("hd-geo/override/scsi_2_controllers",
+ test_override_scsi_2_controllers);
+ }
}
- qtest_add_func("hd-geo/override/virtio_blk", test_override_virtio_blk);
qtest_add_func("hd-geo/override/zero_chs", test_override_zero_chs);
- qtest_add_func("hd-geo/override/scsi_hot_unplug",
- test_override_scsi_hot_unplug);
- qtest_add_func("hd-geo/override/virtio_hot_unplug",
- test_override_virtio_hot_unplug);
+ if (qtest_has_device("virtio-scsi-pci")) {
+ qtest_add_func("hd-geo/override/scsi_hot_unplug",
+ test_override_scsi_hot_unplug);
+ }
+ if (qtest_has_device("virtio-blk-pci")) {
+ qtest_add_func("hd-geo/override/virtio_hot_unplug",
+ test_override_virtio_hot_unplug);
+ qtest_add_func("hd-geo/override/virtio_blk",
+ test_override_virtio_blk);
+ }
if (qtest_has_machine("q35")) {
qtest_add_func("hd-geo/override/sata", test_override_sata);
- qtest_add_func("hd-geo/override/virtio_blk_q35",
- test_override_virtio_blk_q35);
qtest_add_func("hd-geo/override/zero_chs_q35",
test_override_zero_chs_q35);
if (qtest_has_device("lsi53c895a")) {
qtest_add_func("hd-geo/override/scsi_q35",
test_override_scsi_q35);
}
- qtest_add_func("hd-geo/override/scsi_hot_unplug_q35",
- test_override_scsi_hot_unplug_q35);
- qtest_add_func("hd-geo/override/virtio_hot_unplug_q35",
- test_override_virtio_hot_unplug_q35);
+ if (qtest_has_device("virtio-scsi-pci")) {
+ qtest_add_func("hd-geo/override/scsi_hot_unplug_q35",
+ test_override_scsi_hot_unplug_q35);
+ }
+ if (qtest_has_device("virtio-blk-pci")) {
+ qtest_add_func("hd-geo/override/virtio_hot_unplug_q35",
+ test_override_virtio_hot_unplug_q35);
+ qtest_add_func("hd-geo/override/virtio_blk_q35",
+ test_override_virtio_blk_q35);
+ }
+
}
} else {
g_test_message("QTEST_QEMU_IMG not set or qemu-img missing; "
--
2.35.3
- [PATCH v3 00/12] qtests vs. default devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 01/12] tests/qtest: Skip PXE tests for missing devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 02/12] tests/qtest: Do not run lsi53c895a test if device is not present, Fabiano Rosas, 2023/02/13
- [PATCH v3 03/12] tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c, Fabiano Rosas, 2023/02/13
- [PATCH v3 05/12] tests/qtest: hd-geo-test: Check for missing devices,
Fabiano Rosas <=
- [PATCH v3 04/12] tests/qtest: Don't build virtio-serial-test.c if device not present, Fabiano Rosas, 2023/02/13
- [PATCH v3 06/12] tests/qtest: Fix coding style in device-plug-test.c, Fabiano Rosas, 2023/02/13
- [PATCH v3 07/12] tests/qtest: Skip unplug tests that use missing devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 08/12] tests/qtest: drive_del-test: Skip tests that require missing devices, Fabiano Rosas, 2023/02/13
- [PATCH v3 09/12] tests/qtest: Check for devices in bios-tables-test, Fabiano Rosas, 2023/02/13
- [PATCH v3 10/12] tests/qtest: Do not include hexloader-test if loader device is not present, Fabiano Rosas, 2023/02/13
- [PATCH v3 11/12] tests/qemu-iotests: Require virtio-scsi-pci, Fabiano Rosas, 2023/02/13
- [PATCH v3 12/12] tests/qtest: bios-tables-test: Skip if missing configs, Fabiano Rosas, 2023/02/13