[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] target/arm: Add CPU properties for most v8.3 PAC feature
From: |
Peter Maydell |
Subject: |
Re: [PATCH 7/7] target/arm: Add CPU properties for most v8.3 PAC features |
Date: |
Mon, 13 Feb 2023 17:11:29 +0000 |
On Thu, 2 Feb 2023 at 21:12, Aaron Lindsay <aaron@os.amperecomputing.com> wrote:
>
> Signed-off-by: Aaron Lindsay <aaron@os.amperecomputing.com>
> ---
> target/arm/cpu.h | 5 +++
> target/arm/cpu64.c | 81 ++++++++++++++++++++++++++++++++++++++--------
> 2 files changed, 72 insertions(+), 14 deletions(-)
Do we really need all these properties ? Generally we don't
add CPU properties unless there's a good reason for the
user (or the board/SoC code) to want to flip them. The
more usual case is that we simply enable them on the 'max'
CPU by setting the ID register fields appropriately.
Somewhere in this series you need to add documentation of
the features being implemented to docs/system/arm/emulation.rst
(just a one-liner per FEAT_whatever).
thanks
-- PMM
- Re: [PATCH 3/7] target/arm: Implement v8.3 EnhancedPAC, (continued)
- [PATCH 2/7] target/arm: Implement v8.3 QARMA3 PAC cipher, Aaron Lindsay, 2023/02/02
- [PATCH 4/7] target/arm: Implement v8.3 Pauth2, Aaron Lindsay, 2023/02/02
- [PATCH 5/7] targer/arm: Inform helpers whether a PAC instruction is 'combined', Aaron Lindsay, 2023/02/02
- [PATCH 6/7] target/arm: Implement v8.3 FPAC and FPACCOMBINE, Aaron Lindsay, 2023/02/02
- [PATCH 7/7] target/arm: Add CPU properties for most v8.3 PAC features, Aaron Lindsay, 2023/02/02
- Re: [PATCH 7/7] target/arm: Add CPU properties for most v8.3 PAC features,
Peter Maydell <=