[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7] target/arm: Implement v8.3 EnhancedPAC
From: |
Peter Maydell |
Subject: |
Re: [PATCH 3/7] target/arm: Implement v8.3 EnhancedPAC |
Date: |
Mon, 13 Feb 2023 16:23:26 +0000 |
On Thu, 2 Feb 2023 at 21:12, Aaron Lindsay <aaron@os.amperecomputing.com> wrote:
>
> Signed-off-by: Aaron Lindsay <aaron@os.amperecomputing.com>
> ---
> target/arm/pauth_helper.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/target/arm/pauth_helper.c b/target/arm/pauth_helper.c
> index f525ef7fad..a83956652f 100644
> --- a/target/arm/pauth_helper.c
> +++ b/target/arm/pauth_helper.c
> @@ -347,11 +347,15 @@ static uint64_t pauth_addpac(CPUARMState *env, uint64_t
> ptr, uint64_t modifier,
> */
> test = sextract64(ptr, bot_bit, top_bit - bot_bit);
> if (test != 0 && test != -1) {
> - /*
> - * Note that our top_bit is one greater than the pseudocode's
> - * version, hence "- 2" here.
> - */
> - pac ^= MAKE_64BIT_MASK(top_bit - 2, 1);
> + if (cpu_isar_feature(aa64_pauth_epac, env_archcpu(env))) {
> + pac = 0;
> + } else {
> + /*
> + * Note that our top_bit is one greater than the pseudocode's
> + * version, hence "- 2" here.
> + */
> + pac ^= MAKE_64BIT_MASK(top_bit - 2, 1);
> + }
> }
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 0/7] Implement Most ARMv8.3 Pointer Authentication Features, Aaron Lindsay, 2023/02/02
- [PATCH 1/7] target/arm: v8.3 PAC ID_AA64ISAR[12] feature-detection, Aaron Lindsay, 2023/02/02
- [PATCH 3/7] target/arm: Implement v8.3 EnhancedPAC, Aaron Lindsay, 2023/02/02
- Re: [PATCH 3/7] target/arm: Implement v8.3 EnhancedPAC,
Peter Maydell <=
- [PATCH 2/7] target/arm: Implement v8.3 QARMA3 PAC cipher, Aaron Lindsay, 2023/02/02
- [PATCH 4/7] target/arm: Implement v8.3 Pauth2, Aaron Lindsay, 2023/02/02
- [PATCH 5/7] targer/arm: Inform helpers whether a PAC instruction is 'combined', Aaron Lindsay, 2023/02/02
- [PATCH 6/7] target/arm: Implement v8.3 FPAC and FPACCOMBINE, Aaron Lindsay, 2023/02/02
- [PATCH 7/7] target/arm: Add CPU properties for most v8.3 PAC features, Aaron Lindsay, 2023/02/02