Re: [PATCH v5 0/8] Eliminate multifd flush

[Juan Quintela]

Juan Quintela <quintela@redhat.com> wrote:
> Hi

nack.

Mail server is giving me a bad time, sorry.

>
> In this v5:
> - Remove RAM Flags documentation (already on PULL request)
> - rebase on top of PULL request.
>
> Please review.
>
> Based-on: <20230213025150.71537-1-quintela@redhat.com>
>           Migration 20230213 patches
>
> In this v4:
> - Rebased on top of migration-20230209 PULL request
> - Integrate two patches in that pull request
> - Rebase
> - Address Eric reviews.
>
> Please review.
>
> In this v3:
> - update to latest upstream.
> - fix checkpatch errors.
>
> Please, review.
>
> In this v2:
> - update to latest upstream
> - change 0, 1, 2 values to defines
> - Add documentation for SAVE_VM_FLAGS
> - Add missing qemu_fflush(), it made random hangs for migration test
>   (only for tls, no clue why).
>
> Please, review.
>
> [v1]
> Upstream multifd code synchronize all threads after each RAM section.  This 
> is suboptimal.
> Change it to only flush after we go trough all ram.
>
> Preserve all semantics for old machine types.
>
> Juan Quintela (4):
>   ram: Document migration ram flags
>   multifd: Create property multifd-sync-after-each-section
>   multifd: Protect multifd_send_sync_main() calls
>   multifd: Only sync once each full round of memory
>
> Leonardo Bras (4):
>   migration/multifd: Change multifd_load_cleanup() signature and usage
>   migration/multifd: Remove unnecessary assignment on
>     multifd_load_cleanup()
>   migration/multifd: Join all multifd threads in order to avoid leaks
>   migration/multifd: Move load_cleanup inside incoming_state_destroy
>
>  qapi/migration.json   | 10 +++++++-
>  migration/migration.h |  1 +
>  migration/multifd.h   |  3 ++-
>  hw/core/machine.c     |  1 +
>  migration/migration.c | 29 ++++++++++++---------
>  migration/multifd.c   | 17 +++++++-----
>  migration/ram.c       | 60 ++++++++++++++++++++++++++++++++++---------
>  7 files changed, 89 insertions(+), 32 deletions(-)