[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 2/8] migration/multifd: Remove unnecessary assignment on multi
From: |
Juan Quintela |
Subject: |
[PATCH v5 2/8] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup() |
Date: |
Mon, 13 Feb 2023 09:57:40 +0100 |
From: Leonardo Bras <leobras@redhat.com>
Before assigning "p->quit = true" for every multifd channel,
multifd_load_cleanup() will call multifd_recv_terminate_threads() which
already does the same assignment, while protected by a mutex.
So there is no point doing the same assignment again.
Fixes: b5eea99ec2 ("migration: Add yank feature")
Reported-by: Li Xiaohui <xiaohli@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/multifd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index cac8496edc..3dd569d0c9 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -1025,7 +1025,6 @@ void multifd_load_cleanup(void)
MultiFDRecvParams *p = &multifd_recv_state->params[i];
if (p->running) {
- p->quit = true;
/*
* multifd_recv_thread may hung at MULTIFD_FLAG_SYNC handle code,
* however try to wakeup it without harm in cleanup phase.
--
2.39.1
- [PATCH v5 0/8] Eliminate multifd flush, Juan Quintela, 2023/02/13
- [PATCH v5 1/8] migration/multifd: Change multifd_load_cleanup() signature and usage, Juan Quintela, 2023/02/13
- [PATCH v5 2/8] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup(),
Juan Quintela <=
- [PATCH v5 4/8] migration/multifd: Move load_cleanup inside incoming_state_destroy, Juan Quintela, 2023/02/13
- [PATCH v5 3/8] migration/multifd: Join all multifd threads in order to avoid leaks, Juan Quintela, 2023/02/13
- [PATCH v5 5/8] ram: Document migration ram flags, Juan Quintela, 2023/02/13
- [PATCH v5 6/8] multifd: Create property multifd-sync-after-each-section, Juan Quintela, 2023/02/13
- Re: [PATCH v5 0/8] Eliminate multifd flush, Juan Quintela, 2023/02/13