qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] hw/rtc: Rename rtc_[get|set]_memory -> mc146818rtc_[get|


From: Richard Henderson
Subject: Re: [PATCH 3/3] hw/rtc: Rename rtc_[get|set]_memory -> mc146818rtc_[get|set]_cmos_data
Date: Sat, 11 Feb 2023 14:08:12 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 2/10/23 13:31, Philippe Mathieu-Daudé wrote:
rtc_get_memory() and rtc_set_memory() helpers only work with
TYPE_MC146818_RTC devices. 'memory' in their name refer to
the CMOS region. Rename them as mc146818rtc_get_cmos_data()
and mc146818rtc_set_cmos_data() to be explicit about what
they are doing.

Mechanical change doing:

   $ sed -i -e 's/rtc_set_memory/mc146818rtc_set_cmos_data/g' \
         $(git grep -wl rtc_set_memory)
   $ sed -i -e 's/rtc_get_memory/mc146818rtc_get_cmos_data/g' \
         $(git grep -wl rtc_get_memory)

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
---
  hw/i386/microvm.c            | 22 +++++++-------
  hw/i386/pc.c                 | 58 ++++++++++++++++++------------------
  hw/i386/x86.c                |  4 +--
  hw/ppc/prep.c                |  8 ++---
  hw/rtc/mc146818rtc.c         |  6 ++--
  include/hw/rtc/mc146818rtc.h |  4 +--
  6 files changed, 51 insertions(+), 51 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]