Re: [PATCH 2/3] hw/rtc/mc146818rtc: Pass MC146818RtcState instead of ISADevice argument

[Richard Henderson]

On 2/10/23 13:31, Philippe Mathieu-Daudé wrote:
> rtc_get_memory() and rtc_set_memory() methods can not take any
> TYPE_ISA_DEVICE object. They expect a TYPE_MC146818_RTC one.
>
> Simplify the API by passing a MC146818RtcState.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/i386/microvm.c            |  6 ++----
>   hw/i386/pc.c                 | 16 +++++++++-------
>   hw/i386/x86.c                |  4 +++-
>   hw/ppc/prep.c                |  3 +--
>   hw/rtc/mc146818rtc.c         | 13 ++++++-------
>   include/hw/rtc/mc146818rtc.h |  8 ++++----
>   6 files changed, 25 insertions(+), 25 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~