[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/4] migration/multifd: Remove unnecessary assignment on m
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v1 2/4] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup() |
|
Date: |
Fri, 10 Feb 2023 12:19:55 -0500 |
On Fri, Feb 10, 2023 at 03:36:29AM -0300, Leonardo Bras wrote:
> Before assigning "p->quit = true" for every multifd channel,
> multifd_load_cleanup() will call multifd_recv_terminate_threads() which
> already does the same assignment, while protected by a mutex.
>
> So there is no point doing the same assignment again.
>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Leonardo Bras, 2023/02/10
- [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Leonardo Bras, 2023/02/10
- [PATCH v1 2/4] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup(), Leonardo Bras, 2023/02/10
- [PATCH v1 3/4] migration/multifd: Join all multifd threads in order to avoid leaks, Leonardo Bras, 2023/02/10
- [PATCH v1 4/4] migration/multifd: Move load_cleanup inside incoming_state_destroy, Leonardo Bras, 2023/02/10
- Re: [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Juan Quintela, 2023/02/10
- Re: [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Peter Xu, 2023/02/10