[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/4] migration/multifd: Join all multifd threads in order
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v1 3/4] migration/multifd: Join all multifd threads in order to avoid leaks |
|
Date: |
Fri, 10 Feb 2023 13:49:42 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Leonardo Bras <leobras@redhat.com> wrote:
> Current approach will only join threads that are still running.
>
> For the threads not joined, resources or private memory are always kept in
> the process space and never reclaimed before process end, and this risks
> serious memory leaks.
>
> This should usually not represent a big problem, since multifd migration
> is usually just ran at most a few times, and after it succeeds there is
> not much to be done before exiting the process.
>
> Yet still, it should not hurt performance to join all of them.
>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
- [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Leonardo Bras, 2023/02/10
- [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Leonardo Bras, 2023/02/10
- [PATCH v1 2/4] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup(), Leonardo Bras, 2023/02/10
- [PATCH v1 3/4] migration/multifd: Join all multifd threads in order to avoid leaks, Leonardo Bras, 2023/02/10
- [PATCH v1 4/4] migration/multifd: Move load_cleanup inside incoming_state_destroy, Leonardo Bras, 2023/02/10
- Re: [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Juan Quintela, 2023/02/10
- Re: [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage, Peter Xu, 2023/02/10