Re: [PULL 00/17] Migration 20230209 patches

[Peter Maydell]

On Fri, 10 Feb 2023 at 16:13, Juan Quintela <quintela@redhat.com> wrote:
> Again, I don't know why it fails.
>
> diff --git a/tests/bench/meson.build b/tests/bench/meson.build
> index daefead58d..7477a1f401 100644
> --- a/tests/bench/meson.build
> +++ b/tests/bench/meson.build
> @@ -3,9 +3,11 @@ qht_bench = executable('qht-bench',
>                         sources: 'qht-bench.c',
>                         dependencies: [qemuutil])
>
> +if have_system
>  xbzrle_bench = executable('xbzrle-bench',
>                         sources: 'xbzrle-bench.c',
>                         dependencies: [qemuutil,migration])
> +endif
>
>  executable('atomic_add-bench',
>             sources: files('atomic_add-bench.c'),
>
> This make it works.

Before you added your test, meson had no need to compile
any of the object files in 'migration', so it didn't. Now
you tell meson to build a new executable, and it says "OK,
I must build these object files". Only it turns out that
they won't actually compile in this config, so you get an
error.

The same issue can happen in good old Make :-)

thanks
-- PMM