Re: [PULL 00/17] Migration 20230209 patches

[Juan Quintela]

Peter Maydell <peter.maydell@linaro.org> wrote:
> On Thu, 9 Feb 2023 at 23:35, Juan Quintela <quintela@redhat.com> wrote:
>>
>> The following changes since commit 417296c8d8588f782018d01a317f88957e9786d6:
>>
>>   tests/qtest/netdev-socket: Raise connection timeout to 60 seconds 
>> (2023-02-09 11:23:53 +0000)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.com/juan.quintela/qemu.git 
>> tags/migration-20230209-pull-request
>>
>> for you to fetch changes up to 858191aebda251a4d1e3bc77b238096673241cdd:
>>
>>   migration: Postpone postcopy preempt channel to be after main (2023-02-09 
>> 21:26:02 +0100)
>>
>> ----------------------------------------------------------------
>> Migration Pull request
>>
>> Hi
>>
>> This are all the reviewed patches for migration:
>> - AVX512 support for xbzrle (Ling Xu)
>> - /dev/userfaultd support (Peter Xu)
>> - Improve ordering of channels (Peter Xu)
>> - multifd cleanups (Li Zhang)
>> - Remove spurious files from last merge (me)
>>   Rebase makes that to you
>> - Fix mixup between state_pending_{exact,estimate} (me)
>> - Cache RAM size during migration (me)
>> - cleanup several functions (me)
>>
>> Please apply.
>>
>> ----------------------------------------------------------------
>
> Fails to build the user-mode emulators:

This is weird.

$ ls *user -d
aarch64_be-linux-user   m68k-linux-user          ppc-linux-user
aarch64-linux-user      microblazeel-linux-user  riscv32-linux-user
alpha-linux-user        microblaze-linux-user    riscv64-linux-user
armeb-linux-user        mips64el-linux-user      s390x-linux-user
arm-linux-user          mips64-linux-user        sh4eb-linux-user
bsd-user                mipsel-linux-user        sh4-linux-user
common-user             mips-linux-user          sparc32plus-linux-user
cris-linux-user         mipsn32el-linux-user     sparc64-linux-user
hexagon-linux-user      mipsn32-linux-user       sparc-linux-user
hppa-linux-user         nios2-linux-user         x86_64-linux-user
i386-linux-user         or1k-linux-user          xtensaeb-linux-user
linux-user              ppc64le-linux-user       xtensa-linux-user
loongarch64-linux-user  ppc64-linux-user


I think I build all user emulators locally.

> https://gitlab.com/qemu-project/qemu/-/jobs/3749435025
>
> In file included from ../authz/base.c:24:
> ../authz/trace.h:1:10: fatal error: trace/trace-authz.h: No such file
> or directory
> 1 | #include "trace/trace-authz.h"

This series only have one change for traces:

diff --git a/util/trace-events b/util/trace-events
index c8f53d7d9f..16f78d8fe5 100644
--- a/util/trace-events
+++ b/util/trace-events
@@ -93,6 +93,7 @@ qemu_vfio_region_info(const char *desc, uint64_t region_ofs, 
uint64_t region_siz
 qemu_vfio_pci_map_bar(int index, uint64_t region_ofs, uint64_t region_size, 
int ofs, void *host) "map region bar#%d addr 0x%"PRIx64" size 0x%"PRIx64" ofs 
0x%x host %p"
 
 #userfaultfd.c
+uffd_detect_open_mode(int mode) "%d"
 uffd_query_features_nosys(int err) "errno: %i"
 uffd_query_features_api_failed(int err) "errno: %i"
 uffd_create_fd_nosys(int err) "errno: %i"

Rest of trace mentions are for the removal of migration.multifd.c.orig

And I don't play with authentication at all.

This is Fedora 37.

> https://gitlab.com/qemu-project/qemu/-/jobs/3749435094
> In file included from ../authz/simple.c:23:
> ../authz/trace.h:1:10: fatal error: trace/trace-authz.h: No such file
> or directory

Problem is that this trace file is not generated, but I can think how
any change that I did can influence this.

> 1 | #include "trace/trace-authz.h"
>
>
> https://gitlab.com/qemu-project/qemu/-/jobs/3749434963
> In file included from ../authz/listfile.c:23:
> ../authz/trace.h:1:10: fatal error: trace/trace-authz.h: No such file
> or directory
> 1 | #include "trace/trace-authz.h"

Looking at the ouptut of these, they are not informatives at all.

I am going to try to compile linux-user without system, and see if that
brings a clue.

But I don't know what is going on here.

Later, Juan.