[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] include/hw: Do not include "hw/registerfields.h" in headers
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] include/hw: Do not include "hw/registerfields.h" in headers that don't need it |
|
Date: |
Fri, 10 Feb 2023 13:42:34 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 |
On 10/2/23 12:23, Thomas Huth wrote:
Include "hw/registerfields.h" in the .c files instead (if needed).
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/hw/arm/smmuv3.h | 1 -
include/hw/char/ibex_uart.h | 1 -
include/hw/ssi/ibex_spi_host.h | 1 -
hw/char/ibex_uart.c | 1 +
hw/ssi/ibex_spi_host.c | 1 +
5 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/hw/arm/smmuv3.h b/include/hw/arm/smmuv3.h
index f1921fdf9e..b6dd087526 100644
--- a/include/hw/arm/smmuv3.h
+++ b/include/hw/arm/smmuv3.h
@@ -20,7 +20,6 @@
#define HW_ARM_SMMUV3_H
#include "hw/arm/smmu-common.h"
-#include "hw/registerfields.h"
Never required.
#define TYPE_SMMUV3_IOMMU_MEMORY_REGION "smmuv3-iommu-memory-region"
diff --git a/include/hw/char/ibex_uart.h b/include/hw/char/ibex_uart.h
index a39985516a..9deadf223b 100644
--- a/include/hw/char/ibex_uart.h
+++ b/include/hw/char/ibex_uart.h
@@ -26,7 +26,6 @@
#define HW_IBEX_UART_H
#include "hw/sysbus.h"
-#include "hw/registerfields.h"
Missed in bdc36ce649 ("hw/char/ibex_uart: Make the register layout
private").
#include "chardev/char-fe.h"
#include "qemu/timer.h"
#include "qom/object.h"
diff --git a/include/hw/ssi/ibex_spi_host.h b/include/hw/ssi/ibex_spi_host.h
index 1f6d077766..8089cc1c31 100644
--- a/include/hw/ssi/ibex_spi_host.h
+++ b/include/hw/ssi/ibex_spi_host.h
@@ -32,7 +32,6 @@
#include "hw/ssi/ssi.h"
#include "qemu/fifo8.h"
#include "qom/object.h"
-#include "hw/registerfields.h"
Never required.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>