Re: [RFC PATCH] Do not include "qemu/error-report.h" in headers that do not need it

[Philippe Mathieu-Daudé]

On 10/2/23 12:19, Thomas Huth wrote:
> Include it in the .c files instead that use the error reporting
> functions.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   RFC since it's more lines of code - but I think it's still cleaner
>   this way.

This is less pressure on the various .c files including these .h,
so it is an improvement IMO.

>   include/hw/arm/allwinner-a10.h   | 1 -
>   include/qemu/vhost-user-server.h | 1 -
>   include/ui/console.h             | 1 -
>   hw/display/vhost-user-gpu.c      | 1 +
>   hw/display/virtio-gpu-virgl.c    | 1 +
>   hw/misc/applesmc.c               | 1 +
>   ui/console.c                     | 1 +
>   ui/egl-headless.c                | 1 +
>   ui/spice-app.c                   | 1 +
>   ui/spice-display.c               | 1 +
>   ui/udmabuf.c                     | 1 +
>   ui/vdagent.c                     | 1 +
>   util/vhost-user-server.c         | 1 +
>   13 files changed, 10 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>