qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/6] migration: moved hmp_split_at_commma() helper func to


From: Het Gala
Subject: Re: [PATCH v2 1/6] migration: moved hmp_split_at_commma() helper func to qapi-util.c file
Date: Thu, 9 Feb 2023 19:00:19 +0530
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1


On 09/02/23 5:32 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:55AM +0000, Het Gala wrote:
renamed hmp_split_at_comma() --> str_split_at_comma()
Shifted helper function to qapi-util.c file. Give external linkage, as
this function will be handy in coming commit for migration.

Minor correction:
g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",", -1)

Suggested-by: Daniel P. Berrange <berrange@redhat.com>
Suggested-by: Manish Mishra <manish.mishra@nutanix.com>
Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
Signed-off-by: Het Gala <het.gala@nutanix.com>
---
  include/monitor/hmp.h  |  1 -
  include/qapi/util.h    |  1 +
  monitor/hmp-cmds.c     | 19 -------------------
  net/net-hmp-cmds.c     |  2 +-
  qapi/qapi-util.c       | 19 +++++++++++++++++++
  stats/stats-hmp-cmds.c |  2 +-
  6 files changed, 22 insertions(+), 22 deletions(-)
I expect this patch can be dropped, since I don't believe it is
correct to be using it in patch 2. I left comments in that other
patch with more details.
Yes Daniel. This patch will be dropped in upcoming version of this patchset.
With regards,
Daniel
Regards,
Het Gala



reply via email to

[Prev in Thread] Current Thread [Next in Thread]