[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/6] migration: moved hmp_split_at_commma() helper func to
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 1/6] migration: moved hmp_split_at_commma() helper func to qapi-util.c file |
Date: |
Thu, 9 Feb 2023 12:02:16 +0000 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Wed, Feb 08, 2023 at 09:35:55AM +0000, Het Gala wrote:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file. Give external linkage, as
> this function will be handy in coming commit for migration.
>
> Minor correction:
> g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",", -1)
>
> Suggested-by: Daniel P. Berrange <berrange@redhat.com>
> Suggested-by: Manish Mishra <manish.mishra@nutanix.com>
> Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
> include/monitor/hmp.h | 1 -
> include/qapi/util.h | 1 +
> monitor/hmp-cmds.c | 19 -------------------
> net/net-hmp-cmds.c | 2 +-
> qapi/qapi-util.c | 19 +++++++++++++++++++
> stats/stats-hmp-cmds.c | 2 +-
> 6 files changed, 22 insertions(+), 22 deletions(-)
I expect this patch can be dropped, since I don't believe it is
correct to be using it in patch 2. I left comments in that other
patch with more details.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[PATCH v2 5/6] migration: Modified 'migrate-incoming' QAPI and HMP side changes on the destination interface., Het Gala, 2023/02/08