[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/12] target/tricore: Fix OPC2_32_RCRW_INSERT translation
From: |
Bastian Koppelmann |
Subject: |
[PULL 03/12] target/tricore: Fix OPC2_32_RCRW_INSERT translation |
Date: |
Wed, 8 Feb 2023 10:14:13 +0100 |
we were mixing up the "c" and "d" registers. We used "d" as a
destination register und "c" as the source. According to the TriCore ISA
manual 1.6 vol 2 it is the other way round.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/653
Message-Id: <20230202120432.1268-4-kbastian@mail.uni-paderborn.de>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 8de4e56b1f..6149d4f5c0 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -5805,8 +5805,8 @@ static void decode_rcrw_insert(DisasContext *ctx)
tcg_gen_movi_tl(temp, width);
tcg_gen_movi_tl(temp2, const4);
- tcg_gen_andi_tl(temp3, cpu_gpr_d[r4], 0x1f);
- gen_insert(cpu_gpr_d[r3], cpu_gpr_d[r1], temp2, temp, temp3);
+ tcg_gen_andi_tl(temp3, cpu_gpr_d[r3], 0x1f);
+ gen_insert(cpu_gpr_d[r4], cpu_gpr_d[r1], temp2, temp, temp3);
tcg_temp_free(temp3);
break;
--
2.39.1
- [PULL 00/12] tricore queue, Bastian Koppelmann, 2023/02/08
- [PULL 01/12] target/tricore: Fix OPC2_32_RCRW_IMASK translation, Bastian Koppelmann, 2023/02/08
- [PULL 02/12] tests/tcg/tricore: Add test for OPC2_32_RCRW_IMASK, Bastian Koppelmann, 2023/02/08
- [PULL 04/12] tests/tcg/tricore: Add test for OPC2_32_RCRW_INSERT, Bastian Koppelmann, 2023/02/08
- [PULL 03/12] target/tricore: Fix OPC2_32_RCRW_INSERT translation,
Bastian Koppelmann <=
- [PULL 05/12] target/tricore: Fix RRPW_DEXTR, Bastian Koppelmann, 2023/02/08
- [PULL 06/12] tests/tcg/tricore: Add tests for RRPW_DEXTR, Bastian Koppelmann, 2023/02/08
- [PULL 07/12] target/tricore: Fix OPC2_32_RRRR_DEXTR, Bastian Koppelmann, 2023/02/08
- [PULL 08/12] tests/tcg/tricore: Add OPC2_32_RRRR_DEXTR tests, Bastian Koppelmann, 2023/02/08
- [PULL 10/12] tests/tcg/tricore: Add LD.BU tests, Bastian Koppelmann, 2023/02/08
- [PULL 09/12] target/tricore: Fix OPC2_32_BO_LD_BU_PREINC, Bastian Koppelmann, 2023/02/08
- [PULL 11/12] target/tricore: Fix OPC1_16_SRO_LD_H translation, Bastian Koppelmann, 2023/02/08
- [PULL 12/12] tests/tcg/tricore: Add test for ld.h, Bastian Koppelmann, 2023/02/08
- Re: [PULL 00/12] tricore queue, Peter Maydell, 2023/02/09