Re: [PATCH 2/6] usb/ohci: Code style fix white space errors

[Peter Maydell]

On Tue, 7 Feb 2023 at 17:36, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> On Tue, 7 Feb 2023, Peter Maydell wrote:
> > On Tue, 31 Jan 2023 at 19:39, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> >>
> >> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> >> ---
> >>  hw/usb/hcd-ohci.c | 162 +++++++++++++++++++++++-----------------------
> >>  1 file changed, 80 insertions(+), 82 deletions(-)
> >>
> >> -    .subsections = (const VMStateDescription*[]) {
> >> +    .subsections = (const VMStateDescription * []) {
> >
> > You might as well leave this one alone. (checkpatch does
> > not analyse this syntax correctly and mistakenly thinks
> > it needs spaces because it's a multiplication...)
>
> I'd add a space before * at least but if this makes checkpatch happy I
> wenr for the second space just to avoid sputious warnings. Should this be
> changed back?

If you use
  git grep -h '\.subsections'|sort |less
you'll see that most preferred is "no spaces", next after
that is "space each side" (probably checkpatch-influenced)
and "space only before" has just one use.

I usually go for "no spaces".

thanks
-- PMM