qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] usb/ohci: Code style fix white space errors


From: BALATON Zoltan
Subject: Re: [PATCH 2/6] usb/ohci: Code style fix white space errors
Date: Tue, 7 Feb 2023 18:34:04 +0100 (CET)

On Tue, 7 Feb 2023, Peter Maydell wrote:
On Tue, 31 Jan 2023 at 19:39, BALATON Zoltan <balaton@eik.bme.hu> wrote:

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/usb/hcd-ohci.c | 162 +++++++++++++++++++++++-----------------------
 1 file changed, 80 insertions(+), 82 deletions(-)

-    .subsections = (const VMStateDescription*[]) {
+    .subsections = (const VMStateDescription * []) {

You might as well leave this one alone. (checkpatch does
not analyse this syntax correctly and mistakenly thinks
it needs spaces because it's a multiplication...)

I'd add a space before * at least but if this makes checkpatch happy I wenr for the second space just to avoid sputious warnings. Should this be changed back?

Regards,
BALATON Zoltan

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM





reply via email to

[Prev in Thread] Current Thread [Next in Thread]