Re: [PATCH v6 19/36] target/arm: Use tcg_gen_atomic_cmpxchg_i128 for CASP

[Philippe Mathieu-Daudé]

On 30/1/23 22:48, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Message-Id: <20221112042555.2622152-3-richard.henderson@linaro.org>
> ---
>   target/arm/helper-a64.h    |  2 --
>   target/arm/helper-a64.c    | 43 ---------------------------
>   target/arm/translate-a64.c | 61 +++++++++++---------------------------
>   3 files changed, 18 insertions(+), 88 deletions(-)

Is it worth extract this pattern:

> +        if (s->be_data == MO_LE) {
> +            tcg_gen_concat_i64_i128(val, t1, t2);

> +        } else {
> +            tcg_gen_concat_i64_i128(val, t2, t1);

> +        }
as a helper for readability ?