Re: [PATCH 02/25] aspeed: Add Supermicro X11 SPI machine type

[Guenter Roeck]

On 1/31/23 23:49, Cédric Le Goater wrote:
> On 2/1/23 06:39, Joel Stanley wrote:
> > On Thu, 19 Jan 2023 at 12:36, Cédric Le Goater <clg@kaod.org> wrote:
> > > From: Guenter Roeck <linux@roeck-us.net>
> > >
> > > supermicrox11-bmc is configured with ast2400-a1 SoC. This does not match
> > > the Supermicro documentation for X11 BMCs, and it does not match the
> > > devicetree file in the Linux kernel.
> >
> > I found this sentence confusing; AFAICT X11 doesn't name a specific
> > motherboard. It appears to be a marketing term for a bunch of
> > different things.
> >
> > > As it turns out, some Supermicro X11 motherboards use AST2400 SoCs,
> > > while others use AST2500.
> > >
> > > Introduce new machine type supermicrox11-spi-bmc with AST2500 SoC
> >
> > How about supermicro-x11spi-bmc? It would match the product name:
> >
> > https://www.supermicro.com/en/products/motherboard/X11SPi-TF
> >
> > as well as the device tree filename.
>
> Indeed,
>
>          model = "X11SPI BMC";
>          compatible = "supermicro,x11spi-bmc", "aspeed,ast2500";
>
> I was the one who suggested the name. Let's change if Guenter agrees.

Sure, any name is fine with me.

Guenter