qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB


From: Peter Xu
Subject: Re: [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB
Date: Tue, 29 Nov 2022 18:17:40 -0500

        On Mon, Nov 21, 2022 at 11:26:33AM -0500, huangy81@chinatelecom.cn 
wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> 
> overity points out a overflow problem when computing MB,
> dirty_ring_size and TARGET_PAGE_SIZE are both 32 bits,
> multiplication will be done as a 32-bit operation, which
> could overflow. Simplify the formula.
> 
> Meanwhile, fix spelling mistake of variable name.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu




reply via email to

[Prev in Thread] Current Thread [Next in Thread]