[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB
From: |
Peter Xu |
Subject: |
Re: [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB |
Date: |
Tue, 29 Nov 2022 18:17:40 -0500 |
On Mon, Nov 21, 2022 at 11:26:33AM -0500, huangy81@chinatelecom.cn
wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> overity points out a overflow problem when computing MB,
> dirty_ring_size and TARGET_PAGE_SIZE are both 32 bits,
> multiplication will be done as a 32-bit operation, which
> could overflow. Simplify the formula.
>
> Meanwhile, fix spelling mistake of variable name.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v2 00/11] migration: introduce dirtylimit capability, huangy81, 2022/11/21
- [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB, huangy81, 2022/11/21
- Re: [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB,
Peter Xu <=
- [PATCH v2 02/11] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit", huangy81, 2022/11/21
- [PATCH v2 03/11] kvm-all: Do not allow reap vcpu dirty ring buffer if not ready, huangy81, 2022/11/21
- [PATCH v2 05/11] qapi/migration: Introduce vcpu-dirty-limit parameters, huangy81, 2022/11/21
- [PATCH v2 06/11] migration: Introduce dirty-limit capability, huangy81, 2022/11/21
- [PATCH v2 08/11] migration: Export dirty-limit time info, huangy81, 2022/11/21