[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/11] softmmu/dirtylimit: Add parameter check for hmp "set_vc
From: |
huangy81 |
Subject: |
[PATCH v2 02/11] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" |
Date: |
Mon, 21 Nov 2022 11:26:34 -0500 |
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
---
softmmu/dirtylimit.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/softmmu/dirtylimit.c b/softmmu/dirtylimit.c
index 940d238..c42eddd 100644
--- a/softmmu/dirtylimit.c
+++ b/softmmu/dirtylimit.c
@@ -515,6 +515,11 @@ void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict
*qdict)
int64_t cpu_index = qdict_get_try_int(qdict, "cpu_index", -1);
Error *err = NULL;
+ if (dirty_rate < 0) {
+ monitor_printf(mon, "invalid dirty page limit %ld\n", dirty_rate);
+ return;
+ }
+
qmp_set_vcpu_dirty_limit(!!(cpu_index != -1), cpu_index, dirty_rate, &err);
if (err) {
hmp_handle_error(mon, err);
--
1.8.3.1
- [PATCH v2 00/11] migration: introduce dirtylimit capability, huangy81, 2022/11/21
- [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB, huangy81, 2022/11/21
- [PATCH v2 02/11] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit",
huangy81 <=
- [PATCH v2 03/11] kvm-all: Do not allow reap vcpu dirty ring buffer if not ready, huangy81, 2022/11/21
- [PATCH v2 05/11] qapi/migration: Introduce vcpu-dirty-limit parameters, huangy81, 2022/11/21
- [PATCH v2 06/11] migration: Introduce dirty-limit capability, huangy81, 2022/11/21
- [PATCH v2 08/11] migration: Export dirty-limit time info, huangy81, 2022/11/21