Re: [PATCH v5 1/2] io: Add support for MSG_PEEK for socket channel

[manish.mishra]

On 29/11/22 7:57 pm, Peter Xu wrote:
> On Tue, Nov 29, 2022 at 04:24:58PM +0530, manish.mishra wrote:
> > On 23/11/22 11:34 pm, Peter Xu wrote:
> > > On Wed, Nov 23, 2022 at 05:27:34PM +0000, manish.mishra wrote:
> > > > MSG_PEEK reads from the peek of channel, The data is treated as
> > > > unread and the next read shall still return this data. This
> > > > support is currently added only for socket class. Extra parameter
> > > > 'flags' is added to io_readv calls to pass extra read flags like
> > > > MSG_PEEK.
> > > >
> > > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.co
> > > > Suggested-by: Daniel P. Berrangé <berrange@redhat.com
> > > > Signed-off-by: manish.mishra <manish.mishra@nutanix.com>
> > > Reviewed-by: Peter Xu <peterx@redhat.com>
> > Hi Peter, Daniel
> >
> > Just wanted to check if both patches in this series are approved or i
> > need to update few more things. Also Peter, for your Review-by to be
> > included do i need to send another patch version or it will be taken up
> > whoever will be merging it?
> No need to resend it for now.
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.qemu.org_Planning_7.2&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=c4KON2DiMd-szjwjggQcuUvTsPWblztAL0gVzaHnNmc&m=VKz-1dQAm60GTS1TgeCxSN7GCerZujf727kNL7OIzxaQGwdxTmmXBlOi4jJyNnGv&s=wnWA4vdxdaNYmEh0ZDD498R4ClO30VnmpOQhsIurs7U&e=
>
> Today should tag rc3, maybe it's too late for such a change to go into this
> release.  It's not a regression of 7.2 so may not be justified either.
>
> Maybe it'll need to wait until the next dev cycle opens.
>
> Thanks,
ok got it, thank you Peter.

Thanks

Manish Mishra